Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLD-6577] Mattermost push-proxy service templating revisit #434

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

phoinixgrr
Copy link
Contributor

@phoinixgrr phoinixgrr commented Jan 3, 2024

Summary

Revisiting service templating for the push-proxy chart.

When service.type is set to LoadBalancer, optionally exposing ports HTTP (80) and HTTPS (443).
This is particularly beneficial in situations where service.type is set to LoadBalancer instead of ClusterIP and/or using Ingress

Service Manifest continues to render as expected

> helm template charts/mattermost-push-proxy 
[...]
# Source: mattermost-push-proxy/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: release-name-mattermost-push-proxy
  labels:
    app.kubernetes.io/name: mattermost-push-proxy
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
    helm.sh/chart:  mattermost-push-proxy-0.10.3
spec:
  type: ClusterIP
  ports:
    - name: mattermost-push-proxy
      port: 8066
      targetPort: 8066
      protocol: TCP
  selector:
    app.kubernetes.io/name: mattermost-push-proxy
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: server
---
[...]

Ticket Link

https://mattermost.atlassian.net/browse/CLD-6577

Revisiting service templating for the push-proxy chart.

When service.type is set to `LoadBalancer`, exposing ports HTTP (80) and HTTPS (443).
This is particularly beneficial in situations where service.type is set to `LoadBalancer` instead of `ClusterIP` and/or using Ingress

Signed-off-by: phoinixgrr <akis.maziotis@mattermost.com>
@phoinixgrr phoinixgrr force-pushed the CLD-6577-revisit-fixes branch from 2e1d121 to 4ef8080 Compare January 3, 2024 13:19
@phoinixgrr phoinixgrr merged commit cb0546a into master Jan 3, 2024
2 checks passed
@phoinixgrr phoinixgrr deleted the CLD-6577-revisit-fixes branch January 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants