Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Properly register all callback hooks for legacy password authentication providers #11340

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Properly register all callback hooks for legacy password authentication providers #11340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40c1b8c
Properly register all callback hooks for legacy password authenticati…
reivilibre Nov 15, 2021
4110c50
Don't use a dictionary for indirection with the registered hooks
reivilibre Nov 16, 2021
f3c1b2f
Identify the fixed callbacks
reivilibre Nov 16, 2021
415de21
Update synapse/handlers/auth.py
reivilibre Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11340.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug, introduced in Synapse 1.46.0, which caused some callbacks in legacy password authentication provider modules to not be registered. Modules using the generic module API were not affected.
reivilibre marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion synapse/handlers/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,7 @@ def run(*args: Tuple, **kwargs: Dict) -> Awaitable:
# need to use a tuple here for ("password",) not a list since lists aren't hashable
auth_checkers[(LoginType.PASSWORD, ("password",))] = check_password

api.register_password_auth_provider_callbacks(hooks, auth_checkers=auth_checkers)
api.register_password_auth_provider_callbacks(auth_checkers=auth_checkers, **hooks)
reivilibre marked this conversation as resolved.
Show resolved Hide resolved


CHECK_3PID_AUTH_CALLBACK = Callable[
Expand Down