Disable tests for the @cancellable flag on BaseFederationServlet …

…methods Signed-off-by: Sean Quah <seanq@element.io>
matrix-org · Apr 28, 2022 · ba660e5 · ba660e5
1 parent aa0688f
commit ba660e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/synapse/federation/transport/server/_base.py b/synapse/federation/transport/server/_base.py
@@ -376,6 +376,8 @@ def register(self, server: HttpServer) -> None:
             if is_method_cancellable(code):
                 # The wrapper added by `self._wrap` will inherit the cancellable flag,
                 # but the wrapper itself does not support cancellation yet.
+                # Once resolved, the cancellation tests in
+                # `tests/federation/transport/server/test__base.py` can be re-enabled.
                 raise Exception(
                     f"{self.__class__.__name__}.on_{method} has been marked as "
                     "cancellable, but federation servlets do not support cancellation "

diff --git a/tests/federation/transport/server/test__base.py b/tests/federation/transport/server/test__base.py
@@ -59,6 +59,8 @@ class BaseFederationServletCancellationTests(
 ):
     """Tests for `BaseFederationServlet` cancellation."""
 
+    skip = "`BaseFederationServlet` does not support cancellation yet."
+
     path = f"{CancellableFederationServlet.PREFIX}{CancellableFederationServlet.PATH}"
 
     def create_test_resource(self):