Fix MSC3983 support: only one OTK per device was returned through fed…

…eration (#15770)
matrix-org · Jun 13, 2023 · 59ec4a0 · 59ec4a0
1 parent 0757d59
commit 59ec4a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/15770.bugfix b/changelog.d/15770.bugfix
@@ -0,0 +1 @@
+Fix requesting multiple keys at once over federation, related to [MSC3983](/~https://github.com/matrix-org/matrix-spec-proposals/pull/3983).
diff --git a/synapse/federation/federation_server.py b/synapse/federation/federation_server.py
@@ -1016,7 +1016,9 @@ async def on_claim_client_keys(
             for user_id, device_keys in result.items():
                 for device_id, keys in device_keys.items():
                     for key_id, key in keys.items():
-                        json_result.setdefault(user_id, {})[device_id] = {key_id: key}
+                        json_result.setdefault(user_id, {}).setdefault(device_id, {})[
+                            key_id
+                        ] = key
 
         logger.info(
             "Claimed one-time-keys: %s",
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix requesting multiple keys at once over federation, related to [MSC3983](/~https://github.com/matrix-org/matrix-spec-proposals/pull/3983).