-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec reference relationships #1206
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
22a11b3
Spec reference relationships
turt2live 9dee6d9
Apply suggestions from code review
turt2live 2974d8a
Merge branch 'main' into travis/ref-rel
turt2live b65ad68
Merge branch 'main' into travis/ref-rel
turt2live 0add77d
Merge branch 'main' into travis/ref-rel
turt2live 3cc1b38
Edits per code review
turt2live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add `m.reference` relations, as per [MSC3267](/~https://github.com/matrix-org/matrix-spec-proposals/pull/3267). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
--- | ||
type: module | ||
--- | ||
|
||
### Reference relations | ||
|
||
{{% added-in v="1.4" %}} | ||
|
||
Generically referencing another event can be done with a `rel_type` of `m.reference` | ||
as a form of [relationship](#forming-relationships-between-events). There is no | ||
implied meaning behind the reference, and is usually context-dependent. One | ||
example is the [key verification framework](#key-verification-framework) which uses | ||
reference relations to associate distinct events with a specific verification attempt. | ||
|
||
{{% boxes/note %}} | ||
Clients which wish to use threads or replies are expected to use other relationship | ||
types than references. References are typically used to associate data rather than | ||
messages. | ||
{{% /boxes/note %}} | ||
|
||
#### Server behaviour | ||
|
||
##### Server-side aggregation of `m.reference` | ||
|
||
The aggregation format of `m.reference` relations consists of a single `chunk` property, | ||
which lists all the events which `m.reference` the event (the parent). Currently, | ||
only a single `event_id` field is present on the events in the `chunk`. | ||
|
||
An example `m.reference` would be: | ||
|
||
```json | ||
{ | ||
"content": { | ||
"m.relates_to": { | ||
"rel_type": "m.reference", | ||
"event_id": "$another_event" | ||
} | ||
// other content fields as required | ||
} | ||
// other fields as required by events | ||
} | ||
``` | ||
|
||
The [bundle](#aggregations) under `m.relations` would appear similar to the following: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/bundle/aggregation/ ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a bundle, in reference to the same language |
||
|
||
```json | ||
{ | ||
"m.reference": { | ||
"chunk": [ | ||
{ "event_id": "$one" }, | ||
{ "event_id": "$two" } | ||
] | ||
} | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed recently that I'd forgotten to update the table at https://spec.matrix.org/unstable/client-server-api/#summary for message edits. We should probably do so for threading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, we should indeed. Will take a look in a different PR.