This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make TintableSvg links behave like normal image links #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Nov 15, 2017
| <TintableSvg | ||
| src={this.props.src} | ||
| ></TintableSvg> | ||
| <span |
There was a problem hiding this comment.
How come we need another span here? Can't we put this in the parent span?
There was a problem hiding this comment.
The child span needs to float over the top of the SVG in order to display the tooltip on hover.
|
@ara4n LGTMed. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tintableSvg links behave differently from normal image links / buttons - No alt / title text, cursor pointer styling not inherited etc.
Add a TintableSvgButton wrapper to enable tintable SVGs to behave in the same way as images with onClick handlers.
Modify Tinter.js to invert black SVG "lowlights" in a similar fashion to white "highlights", if needed by the current theme.
Depends upon - element-hq/element-web#5605