Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply more general fix for base avatar regressions #10045

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Apply more general fix for base avatar regressions #10045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions res/css/structures/_UserMenu.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ limitations under the License.

.mx_UserMenu_userAvatar {
position: relative;
/* without this a default avatar will cause this to be 4px oversized and out of alignment */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually: without this a default avatar will cause this to be 4px oversized and out of alignment 🙃

display: inherit;

.mx_BaseAvatar {
pointer-events: none; /* makes the avatar non-draggable */
Expand Down
11 changes: 1 addition & 10 deletions res/css/views/avatars/_BaseAvatar.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,7 @@ limitations under the License.

.mx_BaseAvatar {
position: relative;
/* In at least Firefox, the case of relative positioned inline elements */
/* (such as mx_BaseAvatar) with absolute positioned children (such as */
/* mx_BaseAvatar_initial) is a dark corner full of spider webs. It will give */
/* different results during full reflow of the page vs. incremental reflow */
/* of small portions. While that's surely a browser bug, we can avoid it by */
/* using `inline-block` instead of the default `inline`. */
/* /~https://github.com/vector-im/element-web/issues/5594 */
/* https://bugzilla.mozilla.org/show_bug.cgi?id=1535053 */
/* https://bugzilla.mozilla.org/show_bug.cgi?id=255139 */
display: inline-block;
display: block;
user-select: none;

&.mx_RoomAvatar_isSpaceRoom {
Expand Down