Send marker events in all federation tests (MSC2716) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The marker event is important to let the remote homeservers know there are historical messages at the given insertion event it points to. It's just a lucky happen-stance that the tests passed before without the need for the marker event. Marker events are required/expected in order for the history to be properly visible on remote homservers.
MadLittleMods
force-pushed
the
madlittlemods/move-federation-tests-under-a-section
branch
from
fdf4b30 to
7679e69
Compare
kegsay
approved these changes
Dec 17, 2021
|
Thanks for the review @kegsay 🐵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send marker events in all federation tests 🎯
The marker event is important to let remote homeservers know there are historical messages at the given insertion event it points to.
It's just a lucky happen-stance that the tests passed before without the need for the marker event. Marker events are required/expected in order for the history to be properly visible on remote homeservers.
Part of MSC2716: matrix-org/matrix-spec-proposals#2716
Split out from #214