Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Nimble (9.2.0) #374

Merged
merged 2 commits into from
May 12, 2021
Merged

⬆️ Nimble (9.2.0) #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf0fb9
⬆️ Nimble (9.2.0)
chris-araman May 9, 2021
d3dc9c1
🚨 Version bumps are now tracked as git tags, not source changes
chris-araman May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Dangerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,12 @@
has_app_changes = !git.modified_files.grep(/Sources/).empty?
has_test_changes = !git.modified_files.grep(/Tests/).empty?

is_version_bump = git.modified_files.sort == [
"Package.swift",
"MasKit/Package.swift"
].sort
message(":bookmark: Version bump!") if is_version_bump

# if has_app_changes && !has_test_changes && !is_version_bump
# if has_app_changes && !has_test_changes
# warn("Tests were not updated", sticky: false)
# end

# Thanks other people!
message(":tada:") if is_version_bump && github.pr_author != "phatblat"
message(":tada:") if github.pr_author != "phatblat"

# Mainly to encourage writing up some reasoning about the PR, rather than just leaving a title
if github.pr_body.length < 5
Expand Down
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"repositoryURL": "/~https://github.com/Quick/Nimble.git",
"state": {
"branch": null,
"revision": "d258c638d9ef214723a857a23f4113773aad28fb",
"version": "9.1.0"
"revision": "af1730dde4e6c0d45bf01b99f8a41713ce536790",
"version": "9.2.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ let package = Package(
dependencies: [
// Dependencies declare other packages that this package depends on.
.package(url: "/~https://github.com/Carthage/Commandant.git", from: "0.18.0"),
.package(url: "/~https://github.com/Quick/Nimble.git", from: "9.1.0"),
.package(url: "/~https://github.com/Quick/Nimble.git", from: "9.2.0"),
.package(url: "/~https://github.com/Quick/Quick.git", from: "4.0.0"),
.package(url: "/~https://github.com/mxcl/PromiseKit.git", from: "6.13.3"),
.package(url: "/~https://github.com/mxcl/Version.git", from: "2.0.0"),
Expand Down