Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): Add a note that mixin.js is patched on Magento >= 2.3.6 #70

Merged
merged 1 commit into from
Feb 2, 2021
Merged

docs(README): Add a note that mixin.js is patched on Magento >= 2.3.6 #70

merged 1 commit into from
Feb 2, 2021

Conversation

jtomaszewski
Copy link
Contributor

Because:

  • the PR for the fix has been merged and released in Magento 2.3.6 (?)
  • this repo also says no patches are needed since Magento 2.3.6

@jtomaszewski
docs(README): Add a note that mixin.js is patched on Magento >= 2.3.6
2aaff17 
Because:

- [the PR](magento/magento2#25587) for the fix has been merged and released in Magento 2.3.6 (?) 
- [this repo](/~https://github.com/integer-net/magento2-requirejs-bundling) also says no patches are needed since Magento 2.3.6
@jtomaszewski
Copy link
Contributor Author

jtomaszewski commented Dec 20, 2020 •
edited
Loading

P.S. Confirmed by both me and #61 (comment) that it works without any patches on 2.4.x .

@krzksz krzksz merged commit 308853f into magesuite:master Feb 2, 2021
@krzksz
Copy link
Collaborator

krzksz commented Feb 2, 2021

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtomaszewski @krzksz