Product review schema with descriptions. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paliarush
requested changes
Sep 27, 2019
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
Closed
Closed
buskamuza
reviewed
Oct 9, 2019
|
|
||
| type ProductReviewRating { | ||
| name: String! @doc(description: "The review rating name for example quality, price.") | ||
| value: Int! @doc(description: "The rating value given by customer. Possible values by default: 1 to 5.") |
There was a problem hiding this comment.
What is "value", in relation to the metadata? Probably should be "string".
Then how can client render "stars"? Like, does "good" mean 1 star or 5 stars?
There was a problem hiding this comment.
Yes, I think you are right.
@nrkapoor please change it and then we can merge the PR.
paliarush
approved these changes
Oct 28, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL schema for product reviews and ratings GraphQL functionality.