Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nginx to make integration tests more deterministic #773

Merged
merged 11 commits into from
Sep 1, 2020

Conversation

macbre
Copy link
Owner

@macbre macbre commented Sep 1, 2020

http-server depends on the Node.js http module that changes from version to version (see Keep-alive header - #769 and nodejs/node#34561).

Let's use nginx as a lightweight static assets server (with gzip and brotli support). Assertions need to be updated to match the new response details (e.g. Server and ETag headers format).

Example

< HTTP/1.1 200 OK
< Server: nginx
< Date: Tue, 01 Sep 2020 11:29:00 GMT
< Content-Type: text/html
< Last-Modified: Tue, 01 Sep 2020 10:37:49 GMT
< Transfer-Encoding: chunked
< Connection: keep-alive
< ETag: W/"5f4e247d-1c7"
< Expires: Wed, 02 Sep 2020 11:29:00 GMT
< Cache-Control: max-age=86400
< Content-Encoding: gzip

@macbre macbre marked this pull request as ready for review September 1, 2020 14:59
@macbre macbre merged commit 31c9c46 into devel Sep 1, 2020
@macbre macbre deleted the nginx-powered-tests branch September 1, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant