Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd_docker 4: Incorporate docker based etcd into Go integration tests #4148

Merged
merged 1 commit into from
Sep 2, 2022
Merged

etcd_docker 4: Incorporate docker based etcd into Go integration tests #4148

merged 1 commit into from
Sep 2, 2022

Conversation

andrewmains12
Copy link
Contributor

@andrewmains12 andrewmains12 commented Aug 29, 2022 •
edited
Loading

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Aug 29, 2022
Closed
Merged
Merged
Closed
Merged
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch from 7b49976 to 8445afb Compare August 30, 2022 14:44
@andrewmains12 andrewmains12 changed the title Incorporate docker based etcd into Go integration tests etcd_docker 4: Incorporate docker based etcd into Go integration tests Aug 30, 2022
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch 3 times, most recently from 50a14e2 to 77ca046 Compare August 30, 2022 16:52
justinjc
justinjc reviewed Aug 30, 2022
View reviewed changes
src/integration/resources/docker/config/prometheus.yml Outdated Show resolved Hide resolved
src/integration/resources/docker/config/prometheus.yml Outdated
# Load rules once and periodically evaluate them according to the global 'evaluation_interval'.
rule_files:
# - "first_rules.yml"
# - "second_rules.yml"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

src/integration/aggregator/aggregator.go Outdated Show resolved Hide resolved
src/integration/resources/inprocess/cluster.go Outdated Show resolved Hide resolved
src/integration/resources/inprocess/dbnode_test.go Outdated Show resolved Hide resolved
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch 2 times, most recently from d7b617c to 2a63e79 Compare August 30, 2022 17:49
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13 branch from 4b364dd to 26bc538 Compare August 30, 2022 21:28
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch 3 times, most recently from 6910f1e to c8b6a12 Compare August 30, 2022 22:01
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13 branch from 0fbfcc1 to bd47234 Compare August 30, 2022 22:13
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch from c8b6a12 to 0580883 Compare August 30, 2022 22:13
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13 branch from bd47234 to c855a4f Compare August 30, 2022 22:57
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch 2 times, most recently from b47a381 to 9398782 Compare August 31, 2022 14:38
Base automatically changed from pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13 to uber/20220830-grpc_update August 31, 2022 15:18
@andrewmains12
etcd_docker 4: Incorporate docker based etcd into Go integration tests
e3a4a1a 
PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch from 9398782 to e3a4a1a Compare August 31, 2022 15:18
justinjc
justinjc approved these changes Aug 31, 2022
View reviewed changes
src/integration/resources/inprocess/cluster.go
@@ -122,17 +125,51 @@ func NewClusterConfigsFromConfigFile(
// NewClusterConfigsFromYAML creates a new ClusterConfigs object from YAML strings
// representing component configs.
func NewClusterConfigsFromYAML(dbnodeYaml string, coordYaml string, aggYaml string) (ClusterConfigs, error) {
var dbCfg dbcfg.Configuration
// "db":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment block still relevant?

@andrewmains12 andrewmains12 merged commit 197a786 into uber/20220830-grpc_update Sep 2, 2022
@andrewmains12 andrewmains12 deleted the pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd branch September 2, 2022 14:50
andrewmains12 added a commit that referenced this pull request Oct 14, 2022
@andrewmains12
etcd_docker 4: Incorporate docker based etcd into Go integration tests (
d8a7e5d 
#4148)

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
saad-zaman pushed a commit that referenced this pull request Feb 28, 2023
@andrewmains12 @saad-zaman
etcd_docker 4: Incorporate docker based etcd into Go integration tests (
e2e63f5 
#4148)

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
saad-zaman pushed a commit that referenced this pull request Mar 2, 2023
@andrewmains12 @saad-zaman
etcd_docker 4: Incorporate docker based etcd into Go integration tests (
77c6ad3 
#4148)

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
justinjc pushed a commit that referenced this pull request Mar 29, 2023
@andrewmains12 @justinjc
etcd_docker 4: Incorporate docker based etcd into Go integration tests (
2d28cfc 
#4148)

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
andrewmains12 added a commit that referenced this pull request Mar 30, 2023
@andrewmains12
etcd_docker 4: Incorporate docker based etcd into Go integration tests (
a83bb4c 
#4148) (#4206)

PR 4 for #4144

High level approach is as described in #4144 .

This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.

commit-id:3ae12ffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinjc justinjc justinjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewmains12 @justinjc