Make connection quality level depend on strategy #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
👍 I like this simple idea to get that signal from the distributor but I have two comments:
- Variable names suggestion in comments.
- Consider adding to the unit tests to cover this. I think we already have cases that cover both options and it would be easy to just check the output of the
tooLowBandwidhEstimationcall.
| @@ -32,6 +32,10 @@ void StreamPriorityBWDistributor::distribute(uint32_t remb, uint32_t ssrc, | |||
| } | |||
| ELOG_DEBUG("Starting distribution with bitrate %lu for strategy %s", remaining_bitrate, getStrategyId().c_str()); | |||
| strategy_.reset(); | |||
|
|
|||
| bool has_no_default_levels = false; | |||
There was a problem hiding this comment.
These variable names are really confusing to me. I think it's because I think of fallback and slideshow as "default levels". An alternative would be has_no_spatial_levels and distribute_bitrate_to_spatial_levels since we always expect temporal layers there anyway.
Other options are probably fine as long as we avoid default as it's not clear what default is in the context.
jcague
deleted the
update/base_connection_quality_levels_on_stream_priorities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make Connection Quality Levels depend on the BW distributor strategy.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Possible quality levels are now: 'good', 'low' and 'very-low'.
[] It includes documentation for these changes in
/doc.