Plagiarism check: Fix display of escaped characters
#6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
client
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
github-actions
bot
added
the
server
…gfix/plagiarism-escpaed-matches
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
Strohgelaender
dismissed stale reviews from krusche and simon-hng
via
d5accbb
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
rriyaldhi
previously approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Tested on TS1 using this programming exercise: https://artemis-test1.artemis.in.tum.de/course-management/40/programming-exercises/1917
-
Similarity distribution is displayed as expected: https://artemis-test1.artemis.in.tum.de/course-management/40/programming-exercises/1917/plagiarism
-
Code is displayed as expected: https://artemis-test1.artemis.in.tum.de/course-management/40/plagiarism-cases/84
…gfix/plagiarism-escpaed-matches
…gfix/plagiarism-escpaed-matches
Strohgelaender
dismissed stale reviews from stefanwaldhauser and rriyaldhi
via
70460c6
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
bassner
requested changes
Feb 2, 2023
.../plagiarism/plagiarism-split-view/text-submission-viewer/text-submission-viewer.component.ts
Outdated
Show resolved
Hide resolved
.../plagiarism/plagiarism-split-view/text-submission-viewer/text-submission-viewer.component.ts
Outdated
Show resolved
Hide resolved
.../plagiarism/plagiarism-split-view/text-submission-viewer/text-submission-viewer.component.ts
Outdated
Show resolved
Hide resolved
.../plagiarism/plagiarism-split-view/text-submission-viewer/text-submission-viewer.component.ts
Show resolved
Hide resolved
.../plagiarism/plagiarism-split-view/text-submission-viewer/text-submission-viewer.component.ts
Outdated
Show resolved
Hide resolved
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
bassner
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
Plagiarism check: Some characters are presented differently in the code comparison. #6120Description
Plagiarism checks: Fix submission view for submissions with unescaped characters #5991 introduced escaping for the plagiarism view. However, this makes the resulting text longer, and the provided start and end indices of JPlag were no longer valid. In some cases, this leads to a highlighted text starting in between an escaped character as seen in the issue.JPlag 4.1.0 fixed this bug and now returns the correct order. Our workaround code is no longer needed. See Fix similarity distribution in JPlagResult jplag/JPlag#794
Steps for Testing
This is a bit tricky to reproduce since you need a JPlag match stating directly after an
>character.Run a new plagiarism check and see that the chart displays the results correctly.
Test Coverage
unchanged