Multiview prototype as of July, 24 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
6909478 to
71681e3
Compare
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
a75e1cd to
24217bf
Compare
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
4aa5cf9 to
de324a7
Compare
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
c3d417c to
fe40738
Compare
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
e9eba61 to
22853d1
Compare
dkwingsmt
force-pushed
the
multiview-prototype
branch
from
4e3649f to
868a779
Compare
…1106) https://skia.googlesource.com/skia.git/+log/01d9566c4db8..5961ed9c1d99 2024-02-29 bungeman@google.com Have textshaper_harfbuzz_icu direct depend 2024-02-29 johnstiles@google.com Revert "Reland "[graphite] Enable SmallPathAtlas."" 2024-02-29 johnstiles@google.com Revert "[graphite] Rasterize SmallPathAtlas paths to the Plot backing store." 2024-02-29 jvanverth@google.com [graphite] Rasterize SmallPathAtlas paths to the Plot backing store. 2024-02-29 johnstiles@google.com Reland "Delete legacy shadeSpan implementation of Perlin Noise." 2024-02-29 kschmi@microsoft.com Expose min and max contrast and gamma values publicly 2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 12f9cddb3ff7 to 0c9fdfc6c483 (2 revisions) 2024-02-29 kjlubick@google.com Fix failures associated with skshaper refactor 2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from c288d62eb31b to dd050a5bef8f (4 revisions) 2024-02-29 kjlubick@google.com Make SkShaper more modular 2024-02-29 jvanverth@google.com Reland "[graphite] Enable SmallPathAtlas." 2024-02-29 robertphillips@google.com Manual Roll Dawn from aa0be6f5777f to c288d62eb31b (14 revisions) 2024-02-29 nscobie@google.com Update gn/gn_to_bp.py to allowlist only certain extensions in srcs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/5961ed9c1d99..002f4366e473 2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dd050a5bef8f to 0b135d53cd80 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/002f4366e473..d672d0fe2f0d 2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d92d5744e419 to f5ba03c10e1a 2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 983e5c4c3486 to d92d5744e419 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/d672d0fe2f0d..b44ad3d40f54 2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4d362242673e to 2ee295b475ec (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/b44ad3d40f54..a57372ca2e66 2024-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0c9fdfc6c483 to 49ae911d780a (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Would fail to link when using it in a Flutter app.
This is a prototype of the [PlatformIsolate API](flutter/flutter#136314). **UPDATE (Jan 25):** The PR is ready for review. PTAL. The `PlatformIsolate` creation flow is: 1. `PlatformIsolate.spawn` running on parent isolate (platform_isolate.dart) a. Create `isolateReadyPort` b. `PlatformIsolateNativeApi::Spawn` (platform_isolate.cc) c. `DartIsolate::CreatePlatformIsolate` (dart_isolate.cc) d. Isolate created. Entry point invocation task dispatched to platform thread e. `PlatformIsolate.spawn` returns a `Future<Isolate>` 2. On the platform thread, `_platformIsolateMain` is invoked in the platform isolate a. Create `entryPointPort` b. Send `Isolate.current` metadata and `entryPointPort` back to the parent isolate via `isolateReadyPort` 3. Back in the parent isolate, `isolateReadyPort.handler` is invoked a. Send the user's `entryPoint` and `message` to the platform isolate via `entryPointPort` b. Use received isolate metadata to create a new `Isolate` representing the platform isolate and complete the `Future<Isolate>` 4. In the platform isolate, `entryPointPort.handler` is invoked a. Run the user's `entryPoint(message)` The engine shutdown flow is handled by `PlatformIsolateManager`, which maintains a set of running platform isolates.
https://skia.googlesource.com/skia.git/+log/a57372ca2e66..dfd933f9930c 2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0b135d53cd80 to d9da44a9929a (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/dfd933f9930c..4b98d7b3ff2d 2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f5ba03c10e1a to 4425aa95d113 2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d92d5744e419 to f5ba03c10e1a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/4b98d7b3ff2d..ff3199348aab 2024-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2ee295b475ec to fc440afa62a7 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/ff3199348aab..9c7d13c05e77 2024-03-04 robertphillips@google.com [graphite] Add more stably keyed SkRuntimeEffects 2024-03-04 johnstiles@google.com Use nmad in pow/log computation. 2024-03-04 mike@reedtribe.org IWYU : std::max needs <algorithm> 2024-03-04 johnstiles@google.com Remove SkShaderBase::appendStages. 2024-03-04 johnstiles@google.com Reland "Remove matrix from PaintingData." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
issue: flutter/flutter#134178 This doesn't yet do textures since there is a bug in rendering mask blurs with textures. [C++, Objective-C, Java style guides]: /~https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This was introduced in flutter#51070 - my grepping for `LOLLIPOP` was too aggressive, and apparently the linter didn't catch this. I think it's just a bug in the linter. Fixes b/327717572, because Google internal tests caught this.
https://skia.googlesource.com/skia.git/+log/9c7d13c05e77..f65ecbdfb09c 2024-03-04 robertphillips@google.com [graphite] Add stably keyed 1D and 2D blur SkRuntimeEffects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#51169) Fixes flutter/flutter#144553. Looking roughly at: - <https://stackoverflow.com/questions/42482522/test-recreating-android-activity-using-instrumentation-and-junit4> - <https://stackoverflow.com/questions/10982370/instrumentation-test-for-android-how-to-receive-new-activity-after-orientation> ... and given the fact it's only the rotation tests that seem especially flaky, let's give it a shot? /cc @reidbaker @johnmccutchan if you have other advice.
…tter#51399) - `get isAvailable` -> `SkiaGoldClient.isAvailable()` - `get isLuciEnv` -> `SkiaGoldClient.isLuciEnv()` - Remove unused `SkiaGoldHttpOverrides`
…lidations (flutter#51357) fixes flutter/flutter#145017 This works by removing the conditional compilation for validation and turning them to be fatal in the test runner's main. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: /~https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: /~https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: /~https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: /~https://github.com/flutter/tests [breaking change policy]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: /~https://github.com/flutter/flutter/wiki/Chat
During some new development work that might make transform resets more expensive we realized that the resets were mostly coming from the calls to snap the transform to a pixel translate value and many of those were NOPs since the transform was already on a pixel translate value. This PR will avoid those trivially unnecessary reset operations.
…ates (flutter#51323) This change fixes an issue where IME composition gets interrupted when the `setEditableSizeAndTransform` platform message is received mid-composition. This occurs when a multiline input expands and needs to inform the underlying `textarea` to update its size. Fixes flutter/flutter#134797 Fixes flutter/flutter#98817
…#51421) https://dart.googlesource.com/sdk.git/+log/749988e4d748..2bc8b222d01f 2024-03-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-233.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that Flutter owns the list of defines to add to Skia's build, we don't need to toggle it on or off. This allows Skia to delete the setting (https://skia-review.googlesource.com/c/skia/+/826398) [C++, Objective-C, Java style guides]: /~https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This isn't exactly the right fix, but it is a straight revert to fix flutter/flutter#144213
…LinkTest.WorkaroundForFB13482573 (flutter#51405) - Removes potential source of flakiness where the tests assumes that scheduled block will be performed within certain time period, which, despite the tolerances may not be the case on test runner. - Ensures that `viewDidChangeWindow` notification is not received while invalidating the displayLink and removing the display link view, which could deadlock at the end of `WorkaroundForFB13482573` test because the notification would come while `FlutterDisplayLink` is in `@synchronized` block. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: /~https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: /~https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: /~https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: /~https://github.com/flutter/tests [breaking change policy]: /~https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: /~https://github.com/flutter/flutter/wiki/Chat
…GoldClient`. (flutter#51426) - Replaced manual `StringBuffer()..writeln('stdout: ...')` with a single `SkiaGoldProcessError` constructor. - Updated tests to make sure it's working. _/cc @dnfield @jonahwilliams FYI only._
…#51430) https://dart.googlesource.com/sdk.git/+log/2bc8b222d01f..70ca2323a702 2024-03-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-234.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
…er#51429)" (flutter#51432) Reverts: flutter#51429 Initiated by: bdero Reason for reverting: Engine tree breakage ``` + /b/s/w/ir/cache/builder/src/out/host_release/display_list_region_benchmarks --benchmark_format=json /b/s/w/ir/cache/builder/src/flutter/testing/benchmark/generate_metrics.sh: line 17: /b/s/w/ir/cache/builder/src/out/host_release/display_list_region_benchmarks: No such file or directory ``` Original PR Author: flar Reviewed By: {godofredoc} This change reverts the following previous change: These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
This is a speculative fix for flutter/flutter#144331 . I don't have a repro, but I think this may be due to flutter/flutter#144498 , wherein setting the contents of a texture is unsynchronized.
I.e. a "open issues" and "file an issue" link. --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
### Motivation of the change: Both dart and flutter are using fairly outdated gn-sdk without properly maintained. Currently @hjfreyer is working on version'ed IDK / SDK libs which requires changes in gn-sdk to use the right version of the libs in fuchsia/sdk/obj/{arch}-api-{level} rather than the one in the fuchsia/sdk/arch. But current implementation does not support choosing the right version. ### Blocking issue: The new gn-sdk (in flutter/tools/fuchsia/gn-sdk) generates multiple BUILD.gn files rather than a large BUILD.gn the previous version created. So most of the build rules need to switch from the old `fidl:{api}` build rule to `fidl/{api}` rule. The same change will happen in the dart/sdk, i.e. http://go/dart-reviews/356924. But since the two repos cannot have one single atomic change, changing either side first will cause flutter to break. E.g. the linkage error caused by duplicated symbols will happen if we change the dart/sdk first, since in flutter, it will still refer to the old build rules in the middle. ### Solutions: Ideally we can create redirect rules in the current `build/fuchsia` buildroot tree to redirect the old rules into the new one, so we can make the change in the flutter first then dart/sdk. But creating the rules is not trivial and will only be used once. So an alternative solution is - pause the dart/sdk -> flutter roll - submit dart/sdk change (http://go/dart-reviews/356924) - update this change to manually bring the dart/sdk change, namely the `dart_revision` in the DEPS file and signatures in the ci/licences. - resume the dart/sdk -> flutter roll. But it requires this change itself to be reviewed first, and I'd like to know your opinion before moving forward. See corresponding dart/sdk change at http://go/dart-reviews/356924. ### //build/fuchsia/ from buildroot should be removed after this change. Bug: [b/40935282](https://issues.chromium.org/issues/40935282?pli=1&authuser=0) FYI: @hjfreyer [C++, Objective-C, Java style guides]: /~https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
…r#51433) Closes flutter/flutter#144365. Wasn't able to delete as much as I wanted (it's used by the video-rendering code path), but it should fix the problem we're seeing. I expect this change to remove the bottom (Android-rendered) image from our golden files for `ExternalTexturesTests`.
As written: ```sh flutter % et query builders | grep unopt_arm64 "android_debug_unopt_arm64" config "host_debug_unopt_arm64" config ``` Yay!
…1438) https://skia.googlesource.com/skia.git/+log/52bb1539c5cf..54ecc23acf31 2024-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 14272f958e34 to c73858de2cb7 (6 revisions) 2024-03-14 kjlubick@google.com Remove flutter_defines 2024-03-14 bungeman@google.com Remove SkTypeface::onGetAdvancedMetrics base implementation 2024-03-14 robertphillips@google.com [graphite] Fix ImageWrapTextureMipmapsTest Protected handling 2024-03-14 bungeman@google.com Remove Sfntly support 2024-03-14 lehoangquyen@chromium.org Graphite/Dawn: increase max cached textures' bind groups to 4096. 2024-03-14 fmalita@chromium.org Add GrGLCoreFunctions.h to public.bzl 2024-03-14 kjlubick@google.com Avoid shadowing fStream in SkWuffsCodec 2024-03-14 fmalita@chromium.org [skottie] SkottieTool missing header 2024-03-14 kjlubick@google.com Avoid copying data multiple times in SkCodecImageGenerator 2024-03-14 kjlubick@google.com Fix skottie dependency for canvaskit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR adds a check for the `baseline` value in text layout service tests that appears to be missing. Test-exempt: increasing test coverage only.
Same test as in flutter#51416. This test should pass without the revert here because the StC related changes make the optimized path work again.
…#51441) https://dart.googlesource.com/sdk.git/+log/406955fe6950..03cc4d817056 2024-03-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-236.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#51446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: /~https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Previously the DisplayListBuilder would only pass along bounds for a saveLayer when they were supplied by the caller that was building the DisplayList. This would require Impeller to use post-processing of the EntityPass lists to compute them on its own. DisplayList can now compute those bounds as it builds the DisplayList to save dispatch clients from having to do so on their own. It will also provide an indicator in the case when the caller supplied bounds that ended up being too small to capture all of the content, causing clipping by the layer render target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.