Change watchdog_enabled to use Duration
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not fix the actual issue but alerts users to this unsoundness issue. Also changes the examples so that the parameter isn't set to `true` mindlessly. CC lnicola#9
They need to be `unsafe` because `std::env::remove_var` is unsafe. Fixes lnicola#9.
Also return the value via the return value instead of via an out parameter.
|
Based on top of #13 because it'll likely conflict otherwise. For reviewing, just look at the last commit. |
lnicola
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also return the value via the return value instead of via an out parameter.