Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
- Remove [[maybe_unused]] from selectExtInst
- Remove redundant include
  • Loading branch information
Icohedron committed Jan 21, 2025
1 parent c0f9fa3 commit f1a94b4
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "llvm/IR/IntrinsicsSPIRV.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/raw_ostream.h"

#define DEBUG_TYPE "spirv-isel"

Expand Down Expand Up @@ -271,10 +270,8 @@ class SPIRVInstructionSelector : public InstructionSelector {
bool selectPhi(Register ResVReg, const SPIRVType *ResType,
MachineInstr &I) const;

[[maybe_unused]] bool selectExtInst(Register ResVReg,
const SPIRVType *RestType,
MachineInstr &I,
GL::GLSLExtInst GLInst) const;
bool selectExtInst(Register ResVReg, const SPIRVType *RestType,
MachineInstr &I, GL::GLSLExtInst GLInst) const;
bool selectExtInst(Register ResVReg, const SPIRVType *ResType,
MachineInstr &I, CL::OpenCLExtInst CLInst) const;
bool selectExtInst(Register ResVReg, const SPIRVType *ResType,
Expand Down

0 comments on commit f1a94b4

Please sign in to comment.