[FIRRTL] LowerToHW: guard against folded operations (#7358) (backport) #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LowerToHW we copy the name from FIRRTL ops to the lowered HW ops. We often call `createOrFold` when creating the HW ops, which can mean that there is no operation to copy the name to. We were not properly detecting this scenario, which could cause us to try to copy the name to a null operation. Most ops were already covered under a guard in a generic code path, but div-like and subaccess-like operations needed to be guarded. Some of these problems are impossible to test right now as we require folders to be implemented for some operations.
jackkoenig
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LowerToHW we copy the name from FIRRTL ops to the lowered HW ops. We often call
createOrFoldwhen creating the HW ops, which can mean that there is no operation to copy the name to. We were not properly detecting this scenario, which could cause us to try to copy the name to a null operation. Most ops were already covered under a guard in a generic code path, but div-like and subaccess-like operations needed to be guarded. Some of these problems are impossible to test right now as we require folders to be implemented for some operations.This backports #7358 to 1.62.0 for Chisel 6 users.