Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fetch logs functionality in e2e dashboard UI #340

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

Aman-Codes
Copy link
Contributor

Proposed changes

This PR adds fetch logs functionality in e2e dashboard UI.

Issue

Closes litmuschaos/litmus#3112

Dependency

This PR contains commit of #333 and adds fetch log functionality on top of that.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • I have added necessary documentation (if appropriate)
  • I have added Screenshots or Terminal snippets in the PR comment to validate the successful execution of changes

Screenshots:

image
image
image

@Aman-Codes
Copy link
Contributor Author

@uditgaurav
Copy link
Member

Awesome Thanks @Aman-Codes!

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Nov 22, 2021

@Aman-Codes Whenever we are switching the pipeline through the drop-down, we are getting error. -
Screenshot from 2021-11-22 20-45-39

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Nov 22, 2021

On clicking on commit ids in Portal pipeline, it is taking to litmusgo PTAL

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Nov 22, 2021

First 2 pipeline runs are having a different color, any reason?
Screenshot from 2021-11-22 20-51-43

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Nov 22, 2021

Should we increase size of circle a little bit ? @uditgaurav @Aman-Codes
Screenshot from 2021-11-22 20-53-43

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Nov 22, 2021

There is a time limit, after which the logs & artifacts are removed by github. So, they won't be available after 7 days or 1 month. Looks like we haven't handled the case of unavailability of artifacts or logs. Checked on 6 months old pipeline. - cc: @uditgaurav

Screenshot from 2021-11-22 20-56-21

Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
@Aman-Codes
Copy link
Contributor Author

Hi @Jonsy13 fixed all the given suggestions and redeployed to https://aman-codes.github.io/litmus-e2e/dashboard/

Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
@Aman-Codes
Copy link
Contributor Author

@uditgaurav @Jonsy13
Fixed the GitHub commit link for litmus repo

@uditgaurav uditgaurav merged commit 212f59e into litmuschaos:gh-pages Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants