public-api/viz split 7/8: linkerd-web updates #5559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
added a commit
that referenced
this pull request
Jan 18, 2021
This is based on the branch `alpeb/linkerd-web-public-viz` from #5559. Changes to command files under `cli/cmd`: - Updated `endpoints.go` according to new API interface name. - Updated `version.go`, `dashboard` and `uninstall.go` to pull the viz namespace from `viz.pkg.GetVizNamespace()`. Changes to command files under `viz/cmd`: - `edges.go`, `routes.go`, `stat.go` and `top.go`: point to dependencies that were moved from public-api to viz. Tests are not expected to pass on this one either.
Merged
alpeb
changed the title
alpeb
added a commit
that referenced
this pull request
Jan 18, 2021
This is based on the branch `alpeb/linkerd-web-public-viz` from #5559. Changes to command files under `cli/cmd`: - Updated `endpoints.go` according to new API interface name. - Updated `version.go`, `dashboard` and `uninstall.go` to pull the viz namespace from `viz.pkg.GetVizNamespace()`. Changes to command files under `viz/cmd`: - `edges.go`, `routes.go`, `stat.go` and `top.go`: point to dependencies that were moved from public-api to viz. Tests are not expected to pass on this one either.
alpeb
force-pushed
the
alpeb/linkerd-metrics-api-bootstrap
branch
from
b5a4f46 to
2d9f77e
Compare
This is based on the branch `alpeb/linkerd-metrics-api-bootstrap` from #5558. `linkerd-web` requires connecting with both the public-api and the viz api, so both addresses (and the viz namespace) are now provided as parameters to the container. We're also updating some dependencies that still were pointing to the public-api and now should point to the viz api. Tests are not expected to pass on this one either.
alpeb
force-pushed
the
alpeb/linkerd-web-public-viz
branch
from
7f6cc2f to
3a7a13b
Compare
alpeb
added a commit
that referenced
this pull request
Jan 20, 2021
This is based on the branch `alpeb/linkerd-web-public-viz` from #5559. Changes to command files under `cli/cmd`: - Updated `endpoints.go` according to new API interface name. - Updated `version.go`, `dashboard` and `uninstall.go` to pull the viz namespace from `viz.pkg.GetVizNamespace()`. Changes to command files under `viz/cmd`: - `edges.go`, `routes.go`, `stat.go` and `top.go`: point to dependencies that were moved from public-api to viz. Other changes to have tests pass: - Added `metrics-api` to list of docker images to build in actions workflows. - In `bin/fmt` exclude protobuf generated files instead of entire directories because directories could contain both generated and non-generated code (case in point: `viz/metrics-api`). - Update Helm readme files.
|
Closing in favor of #5560 which will aggregate all these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the branch
alpeb/linkerd-metrics-api-bootstrapfrom #5558.linkerd-webrequires connecting with both the public-api and the viz api, so both addresses (and the viz namespace) are now provided as parameters to the container.We're also updating some dependencies that still were pointing to the public-api and now should point to the viz api.
Tests are not expected to pass on this one either.