public-api/viz split 4/8: remove linkerd-controller dependency on Prometheus #5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
added a commit
that referenced
this pull request
Jan 18, 2021
This is based on the branch `alpeb/no-more-controller-prom` from #5556 We continue removing the linkerd-controller dependencies on viz stuff, except for things required for the tap server, which can be tackled separately afterwards. - Created a new gRPC server under `viz/metrics-api` moving prometheus-dependent functions out of the core gRPC server and into it (same thing for the accompaigning http server). - Did the same for the `PublicAPIClient` (now called just `Client`) interface. The `VizAPIClient` interface disappears as it's enough to just rely on the viz `ApiClient` protobuf type. - Moved the other files implementing the rest of the gRPC functions from `controller/api/public` to `viz/metrics-api` (`edge.go`, `stat_summary.go`, etc.). - Also simplified some type names to avoid stuttering. Tests are not supposed to pass in this branch.
alpeb
changed the title
alpeb
force-pushed
the
alpeb/no-more-controller-prom
branch
from
921527b to
7980741
Compare
alpeb
force-pushed
the
alpeb/viz-healthcheck
branch
from
326daa1 to
18abd97
Compare
…metheus This is based on the branch `alpeb/viz-healthcheck` from #5555 - Removed the `global.prometheusUrl` config in the core values.yml. - Removed `linkerd-controller` dependencies on Prometheus. - Leave the Heartbeat's `-prometheus` flag hard-coded temporarily. TO-DO: have it automatically discover viz and pull Prometheus' endpoint (#5352). Tests are not supposed to pass in this branch. More wiring will come up in the followup PRs.
alpeb
force-pushed
the
alpeb/no-more-controller-prom
branch
from
7980741 to
c512846
Compare
alpeb
added a commit
that referenced
this pull request
Jan 20, 2021
This is based on the branch `alpeb/no-more-controller-prom` from #5556 We continue removing the linkerd-controller dependencies on viz stuff, except for things required for the tap server, which can be tackled separately afterwards. - Created a new gRPC server under `viz/metrics-api` moving prometheus-dependent functions out of the core gRPC server and into it (same thing for the accompaigning http server). - Did the same for the `PublicAPIClient` (now called just `Client`) interface. The `VizAPIClient` interface disappears as it's enough to just rely on the viz `ApiClient` protobuf type. - Moved the other files implementing the rest of the gRPC functions from `controller/api/public` to `viz/metrics-api` (`edge.go`, `stat_summary.go`, etc.). - Also simplified some type names to avoid stuttering. Tests are not supposed to pass in this branch.
|
Closing in favor of #5560 which will aggregate all these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the branch
alpeb/viz-healthcheckfrom #5555global.prometheusUrlconfig in the corevalues.yml.linkerd-controllerdependencies on Prometheus.-prometheusflag hard-coded temporarily. TO-DO: have it automatically discover viz and pull Prometheus' endpoint (heartbeat cron should get metrics from linkerd-viz extension when available #5352).Tests are not supposed to pass in this branch. More wiring will come up in the followup PRs.