Add doc for disabling auth on filter controllers #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jun 22, 2021
|
that looks great, thanks for the research and the pull request! |
lchrusciel
added a commit
to Sylius/Sylius-Standard
that referenced
this pull request
Jun 26, 2021
This PR was merged into the 1.10 branch. Discussion ---------- Ref: https://twitter.com/mbabker/status/1405962888792231939?s=21 and liip/LiipImagineBundle#1383 Most apps don't need authenticated user info when resolving images, so we can sanely disable the security authentication for these routes. Commits ------- d70977b Disable auth for LiipImagineBundle controllers
windragon0910
added a commit
to windragon0910/symfony_ecom_framework
that referenced
this pull request
Oct 25, 2023
This PR was merged into the 1.10 branch. Discussion ---------- Ref: https://twitter.com/mbabker/status/1405962888792231939?s=21 and liip/LiipImagineBundle#1383 Most apps don't need authenticated user info when resolving images, so we can sanely disable the security authentication for these routes. Commits ------- d70977b9497398d7eee184a5f1fdeb557406c06a Disable auth for LiipImagineBundle controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://twitter.com/mbabker/status/1405962888792231939?s=21
App performance can be improved for the
/media/cache/resolve/*routes by disabling Symfony's authentication system. Generally, there isn't much of a need to load the authenticated user data here, and for image-heavy applications (like the one that inspired this change) this can free up resources greatly (historically, theliip_imagine_filtercontroller in our application accounts for 55-60% of the total transaction time for our web frontend, after deployment this dropped down to 40-45%).(RST isn't really a strong-suit for me, so I'm hoping I've got the format here generally right)