Create Lazy-Loaded Twig Extension #1265
Conversation
|
Any chance we could move this forward? Ideally this should maybe be for a next major version (3.0) to avoid possible BC breaks? EDIT: actually meanwhile the twig requirement was updated already and works for this PR: /~https://github.com/liip/LiipImagineBundle/blob/2.x/composer.json#L29 |
| @@ -16,15 +16,13 @@ | |||
|
|
|||
| class FilterExtension extends AbstractExtension | |||
| { | |||
| use FilterTrait; | |||
There was a problem hiding this comment.
considering this class is not marked @internal this is a BC break, or?
|
@dmaicher I deleted the source repository and I cannot update my PR even though I have restored my fork. May I suggest to wipe out my last commit and rebase in git reset --hard HEAD~1
git rebase 2.xOr do you want me to close this PR and open up another one? |
|
@emmanuelballery I don't mind if you open another one 😊 @lsmith77 should this target 2.x? There seems to be no 3.x branch yet. |
|
New PR here #1376, sorry ... |
Hi!
Twig supports Lazy-Loaded Extensions since
1.35.0and2.4.4.However, I don't really know how we can be sure that Twig is indeed
>= 1.35.0or>= 2.4.4.I updated
composer.jsonrequire-devfortwig/twigto^1.35|^2.4.4|^3.0.Tests have been updated too.
(Also, @mbabker provided details and Blackfire comparison in #1261)