Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding outpoint sigs to tx_signatures message #1009

Closed
wants to merge 37 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
bb3eb80
interactive-tx: Add dual-funding flow, using the interactive tx protocol
niftynei Mar 3, 2021
07b9ffb
dual-funding: accept_channel2 must also use the temporary channel-id
niftynei Apr 23, 2021
3dcb9d1
fixup! interactive-tx: Add dual-funding flow, using the interactive t…
niftynei Jun 8, 2021
b2949cd
fixup: remove fee_step from init_rbf in favor of an explicity feerate
niftynei Jul 9, 2021
53371fe
fixup: remove '9' from option_dual_fund flag
niftynei Aug 13, 2021
28dfc1c
fixup: nit, add 'v1' to channel open description
niftynei Aug 13, 2021
25af2c6
fixup: mirror desc of nLocktime, same as others
niftynei Aug 13, 2021
4eb0029
fixup: remove reference to 'DER' encoding
niftynei Aug 13, 2021
89df351
fixup: remove errant 'n'
niftynei Aug 13, 2021
db2bf1d
fixup: clarify exactly what field on `prevtx` should be `OP_1..OP_16`
niftynei Aug 13, 2021
eaaf6fa
fixup: correct name prevtx_tx -> prevtx
niftynei Aug 13, 2021
801166f
fixup: the `script_sig` should be empty, thus an empty array not byte
niftynei Aug 13, 2021
105213d
fixup: add P2TR (pay to taproot) to acceptable address list
niftynei Aug 13, 2021
c2d1a9b
fixup: move mention of failing the channel to implementation section
niftynei Aug 16, 2021
aedaa3a
fixup: use "tx_remove_*" in all places, not "tx_rm_"
niftynei Aug 16, 2021
9d33274
fixup: explicitly note that interactive protocol is turn based
niftynei Aug 16, 2021
3ad9552
fixup: remove temp_chan_id reference, rename channel_id to zerod_chan_id
niftynei Aug 16, 2021
996cdf8
fixup: add 'it'
niftynei Aug 16, 2021
8595a97
fixup: remove 'error' language
niftynei Aug 16, 2021
4670bec
fixup: MAX_MONEY is 21million bitcoins, not satoshis
niftynei Jan 31, 2022
f2d4c89
fixup: show turn based protocol in diagrams
niftynei Jan 31, 2022
e582d83
fixup: use BIP141 text to describe witness version scripts
niftynei Jan 31, 2022
96880f6
fixup: add switch stmt for P2SH-wrapped segwit input verification
niftynei Jan 31, 2022
9346349
fixup: disallow P2SH scripts in outputs
niftynei Jan 31, 2022
d7713de
df: v2 opens use a temp channel id until accept_channel2 is exchanged
niftynei Jan 31, 2022
17bd7ac
v2 opens: add a `tx_abort` message
niftynei Jan 31, 2022
22de9ef
fixup: mistake, should be 110
niftynei Feb 10, 2022
adb6272
Dual funding proposed updates
t-bast Apr 26, 2022
cfd82dc
Merge pull request #3 from t-bast/dual-funding-tbast
niftynei Apr 29, 2022
53b740e
Fix table of contents
t-bast May 2, 2022
1687397
Fix a few typos
t-bast May 4, 2022
6f3583b
Increase RBF increment
t-bast May 10, 2022
124fcfa
dual-fund: update funding transaction test case
niftynei May 13, 2022
ba0f679
dual-fund: tie-break tx_sigs send order on node's pubkey
niftynei May 13, 2022
8dbba62
dual-fund: adjust the minimum witness weight down to 107 (from 110)
niftynei May 16, 2022
e86d4a5
dual-fund: add missing tlv structs to RBF messages
niftynei May 18, 2022
96dc0b7
Add funding outpoint sigs to tx_signatures message
ddustin Jun 30, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .aspell.en.pws
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ nhops
retransmitted
dev
tradeoff
kiloweight
mixHeader
uint
hopsData
Expand Down Expand Up @@ -115,6 +116,17 @@ delayedsig
hopDataSize
I'th
segwit
RBF
accepter
accepter's
subtype
redeemScript
scriptSig
utxo
scriptPubKey
scriptPubKeys
scriptlen
sats
htlc
htlcs
ChaCha
Expand Down Expand Up @@ -387,3 +399,12 @@ CHECKSIGVERIFY
IFDUP
sats
anysegwit
workflow
PUSHDATA
prev
vout
rbf
standardness
perkw
prevtx
ints
12 changes: 10 additions & 2 deletions 01-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,22 @@ The 2-byte `len` field indicates the number of bytes in the immediately followin

The channel is referred to by `channel_id`, unless `channel_id` is 0 (i.e. all bytes are 0), in which case it refers to all channels.

The funding node:
The funding node using channel establishment v1 `open_channel`:
- for all error messages sent before (and including) the `funding_created` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The fundee node:
The fundee node using channel establishment v1 (`accept_channel`):
- for all error messages sent before (and not including) the `funding_signed` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The opener node using channel establishment v2 `open_channel2`:
- for all error messages sent before the `accept_channel2` message is received:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The accepter node using channel establishment v2 `open_channel2`:
- for all error messages sent before (and including) the `accept_channel2` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

A sending node:
- when sending `error`:
- MUST fail the channel referred to by the error message.
Expand Down
Loading