Proposal: add import sorting to the base config #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will result in a major version bump. Created by lifeomic-probot (Enforce Semantic Commits) |
swain
requested review from
shawnzhu,
sternetj,
nicolls1,
aecorredor,
SchaeStewart,
jkdowdle,
rob-snyder,
aymanenadi and
epeters3
aecorredor
approved these changes
Feb 6, 2024
shawnzhu
approved these changes
Feb 6, 2024
epeters3
approved these changes
Feb 6, 2024
SchaeStewart
approved these changes
Feb 6, 2024
jkdowdle
approved these changes
Feb 6, 2024
|
Surprised at the quick widespread approval. Love it. Merging! |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using this plugin to automatically sort imports in an internal project for some time. When combined with ESLint's "fix on save" feature in VSCode, the experience is great. I never have to think about import order, and imports are sorted automatically whenever I save. Plus, the ordering of imports is consistent between files.
My experience has been so great that I'd like to propose adding it to our core config.