fix: have Lake not create core aliases into Lake namespace
#5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 13, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 13, 2024
|
Mathlib CI status (docs):
|
Kha
approved these changes
Oct 17, 2024
This replaces `export Lean (Name NameMap)` and `export System (SearchPath FilePath)` with the relevant `open` commands. This fixes docgen output so that it can refer to, for example, `Lean.Name` instead of `Lake.Name`. The reason for these `export`s was convenience: by doing `open Lake` you could get these aliases for free. However, aliases affect pretty printing, and the Lake aliases took precedence. We don't want to disable pretty printing re-exported names because this can be a valid pattern (names could incrementally get re-exported from namespace to parent namespace). In the future we might implement a feature to be able to `scope export` some names. Closes leanprover#2524
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 20, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 20, 2024
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Oct 27, 2024
…rover#5688) This replaces `export Lean (Name NameMap)` and `export System (SearchPath FilePath)` with the relevant `open` commands. This fixes docgen output so that it can refer to, for example, `Lean.Name` instead of `Lake.Name`. The reason for these `export`s was convenience: by doing `open Lake` you could get these aliases for free. However, aliases affect pretty printing, and the Lake aliases took precedence. We don't want to disable pretty printing re-exported names because this can be a valid pattern (names could incrementally get re-exported from namespace to parent namespace). In the future we might implement a feature to be able to `scoped open` some names. Breaking change: Lakefiles that refer to `FilePath` may need to change this to `System.FilePath` or otherwise add `open System (FilePath)`. Closes leanprover#2524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
export Lean (Name NameMap)andexport System (SearchPath FilePath)with the relevantopencommands. This fixes docgen output so that it can refer to, for example,Lean.Nameinstead ofLake.Name.The reason for these
exports was convenience: by doingopen Lakeyou could get these aliases for free. However, aliases affect pretty printing, and the Lake aliases took precedence. We don't want to disable pretty printing re-exported names because this can be a valid pattern (names could incrementally get re-exported from namespace to parent namespace).In the future we might implement a feature to be able to
scoped opensome names.Breaking change: Lakefiles that refer to
FilePathmay need to change this toSystem.FilePathor otherwise addopen System (FilePath).Closes #2524