Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Data/Fin/Basic): split off rev lemmas #20833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BoltonBailey
Copy link
Collaborator

This PR splits out lemmas about the Fin.rev function from Data.Fin.Basic. This addresses an instance of a long file linter trigger.


Open in Gitpod

@BoltonBailey BoltonBailey added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

PR summary 4b4272b74f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
There are 3900 files with changed transitive imports taking up over 169367 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.02)
Current number Change Type
58 -1 large files

Current commit 4b4272b74f
Reference commit 3c8e6314aa

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-data Data (lists, quotients, numbers, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant