[5.x] Throw exception if config is incomplete #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a breaking change, but I'd consider this a bug fix)
While watching Prime's stream with Taylor and TJ, their oAuth implementation was failing because the
twitchconfig was incomplete.Since it was trying to access an array key on a null variable, the warning was not informative at all (
Trying to access array offset on value of type null). If you're experienced, you sorta know where to look for things, but if you're new this is very confusing.Since
client_id,client_secretandredirectare always expected, this PR simply throws an exception letting the user know what was missing exactly.