Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a _position.yaml for vertex ai provider #13367

Conversation

Riddhimaan-Senapati
Copy link
Contributor

@Riddhimaan-Senapati Riddhimaan-Senapati commented Feb 7, 2025

Summary

The vertex model provider didn't have a _position.yaml files like other providers so I decided to add one.

Fixes #13368

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ⚙️ feat:model-runtime labels Feb 7, 2025
@Riddhimaan-Senapati
Copy link
Contributor Author

@crazywoola Can you tell me what is wrong with the _position.yaml file that I added.

@crazywoola crazywoola mentioned this pull request Feb 8, 2025
83 tasks
@Riddhimaan-Senapati
Copy link
Contributor Author

@crazywoola Now can you review my PR? I got rid of the weird linting error.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2025
@crazywoola crazywoola merged commit 811d72a into langgenius:main Feb 9, 2025
6 checks passed
@crazywoola
Copy link
Member

Please see #13399 (comment) as well
For changes regarding model runtime and tools should move changes to that repo.
@Riddhimaan-Senapati

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _position.yaml file for vertex model provider
2 participants