Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHPUnit ^11 and ^12 #94

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Allow PHPUnit ^11 and ^12 #94

merged 3 commits into from
Feb 25, 2025

Conversation

rieschl
Copy link
Contributor

@rieschl rieschl commented Feb 25, 2025

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Allow installing newer versions of PHPUnit.
In this library itself only PHPUnit ^10 is possible because of the PHP version constraint (PHPUnit ^11 requires at least PHP 8.2). But this PR allows consuming packages to install a newer version of PHPUnit.

PHPUnit 12 requires dataProvider to be attributes, so all dataProvider annotations were converted to attributes. To be able to install PHPUnit 11, psalm ^6 is required, so it was also bumped and some new issues were fixed.

Supersedes #92 and #93

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rieschl. This is really helpful - just a couple of nitpicks and questions :)

Allow installing newer versions of PHPUnit.
In this library itself only PHPUnit ^10 is possible because of the PHP version constraint (PHPUnit ^11 requires at least PHP 8.2).
But this PR allows consuming packages to install a newer version of PHPUnit.

PHPUnit 12 requires dataProvider to be attributes, so all dataProvider annotations were converted to attributes.
To be able to install PHPUnit 11, psalm ^6 is required, so it was also bumped and some new issues were fixed.

Signed-off-by: Thomas Rieschl <thomas@trinet.at>
@gsteel gsteel self-assigned this Feb 25, 2025
@gsteel gsteel added this to the 4.12.0 milestone Feb 25, 2025
@gsteel gsteel added Enhancement Dependencies Updates and changes to dependencies QA Quality assurance tasks such as static analysis improvements labels Feb 25, 2025
Signed-off-by: Thomas Rieschl <thomas@trinet.at>
Signed-off-by: Thomas Rieschl <thomas@trinet.at>
@rieschl rieschl requested a review from gsteel February 25, 2025 15:52
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rieschl 👍

@gsteel gsteel merged commit 9158227 into laminas:4.12.x Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Updates and changes to dependencies Enhancement QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants