Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BN254 Curve for Groth16 #961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nicole-graus
Copy link
Contributor

Add BN254 Curve for Groth16 Prover

Description

This PR allows the use of the curve BN254 to prove and verify proofs using Groth16. It also reorganize the prover's folder to include both curves.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@nicole-graus nicole-graus requested a review from a team as a code owner January 16, 2025 21:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.61210% with 64 lines in your changes missing coverage. Please review.

Project coverage is 71.60%. Comparing base (6fb54a2) to head (61c9765).

Files with missing lines Patch % Lines
provers/groth16/bn_254/src/qap.rs 69.23% 40 Missing ⚠️
provers/groth16/bn_254/src/r1cs.rs 0.00% 23 Missing ⚠️
provers/groth16/bn_254/src/prover.rs 99.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   71.32%   71.60%   +0.28%     
==========================================
  Files         155      163       +8     
  Lines       33537    34099     +562     
==========================================
+ Hits        23920    24418     +498     
- Misses       9617     9681      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants