Compatibility with more recent versions of Ogre #1538

rolalaro · 2025-01-08T16:19:08Z

Fix compatibilities issues with Ogre 1.12.10, 13.1.0 and 14.0.0
Created 2 CIs to check the compilation of ViSP when Ogre is used as 3rd party. Unit tests for Ogre cannot be run because Ogre requires a valid X11 context

…ing Ogre >= 1.10

…d" and "Ogre::WindowEventListener : expected class-name before '{' token"

…rror

Moved detection of the visp-images outside the vp_add_test method, to make the detection possible even when tests are disabled

…ROgre

…cause it seemed to cause a problem when running successive configure steps

…of Ogre

…Ogre

The window did not close when clicking on the [x] button of the window. Now it works

codecov · 2025-01-10T13:27:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@abf3419). Learn more about missing BASE report.
Report is 46 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1538   +/-   ##
=========================================
  Coverage          ?   54.01%           
=========================================
  Files             ?      441           
  Lines             ?    53865           
  Branches          ?        0           
=========================================
  Hits              ?    29095           
  Misses            ?    24770           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Introduce vpDisplayFactory - Remove useless try/catch and other code

fspindle · 2025-01-10T15:19:26Z

@rolalaro AROgre and AROgreBasic are now working with Ogre 1.12.10 installed from ubuntu package.

There remains a segfault when I run ./mbtEdgeKltTracking -c -o or ./mbtGenericTracking -c -w -o

The segfault came from the fact that the rendering window was added to the list of listening windows but not removed when destroyed

rolalaro · 2025-01-14T08:12:08Z

@fspindle the bug should have been fixed in the latest commit, could you please pull and try again ?

I don't see since when OIS 3rdparty detection was removed!

fspindle · 2025-01-18T10:49:06Z

Closes #1547 #1519 #1546

LAGNEAU Romain and others added 30 commits December 4, 2024 15:15

[CORE] Added a macro that indicates the OGRE version

bedffa7

[CORE] Removed a deprecated warning in vpAROgre

3afccd1

[FIX] Fix "no matching function for call to showConfigDialog" when us…

7853efd

…ing Ogre >= 1.10

[FIX] Fixed "error: 'Ogre::WindowEventUtilities' has not been declare…

1715f01

…d" and "Ogre::WindowEventListener : expected class-name before '{' token"

[FIX] Fixed "mBackground->setMaterial(BackgroundMaterial);" related e…

36fe776

…rror

[FIX] Fixed "cannot convert 'Ogre::Matrix4' to 'const Ogre::Affine3&'"

5537544

[FIX] Fixed visp-images dataset detection

8bb0792

Moved detection of the visp-images outside the vp_add_test method, to make the detection possible even when tests are disabled

[FIX] Fixed deprecated warnings due to the setting of the lights in A…

6c7cc06

…ROgre

[FIX] Fixed resource loading and setMaterial issue

9d18137

[FIX] Fix deprecated warning due to createSceneManager

8472d16

[FIX] Fixed deprecated warning due to getSceneManagerIterator

0ea8a35

[WIP] Working on the CMake file for Ogre

31a128b

[CORE] Fixed deprecated warnings due to light->setPosition in tutorials

f6b69c2

[CORE] Add Ogre dir log during CMake configuration if USE_OGRE

2f49d90

[FIX] Initialize the VISP_HAVE_OGRE_RESOURCES_PATH to empty string be…

e675804

…cause it seemed to cause a problem when running successive configure steps

[KO] Pbs : of include in 1.12.10, of linkage in 1.9.0

852dd7a

[FIX] Fixed warnings when loading the resources using Ogre 1.12.10

c5dbc8a

[FIX] Fixed segfault that occured in tuto-ibvs-ogre-tracking

492c99f

[FIX] FIx include + linkage problems for ogre 1.12+

343aea9

[FIX] Fixed CMake errors related to v1.9

963737e

[FIX] Fixed release of the shared ptr for ogre v1.9

2706336

[WIP] Working on a fix for Ogre v1.10 and v1.11

6e01309

[FIX] Fixed compilation error for ogre 1.10

abb8395

[FIX] Avoid creating Ogre targets if they already exist

52745ec

[CLEAN] Solved a warning when using ogre 1.9.1 from apt

bf95f77

[CORE] Added CMakes lines that might be useful for compiled versions …

213589e

…of Ogre

[CLEAN] Removed commented CMake lines

1fdc37b

[CORE] Made vpAROgre compatible with Ogre 13.1.0

4f3e592

Cleanup Ogre location feedback in ViSP-third-party.txt

d1a0749

Merge branch 'master' into ogre-wip

a4aef0b

LAGNEAU Romain added 5 commits January 7, 2025 16:42

[TEST] Fix Ogre CI : Ogre cannot be run without a valid X11 context

988d23d

[TEST] Removed Ogre dependencies in the apt based image

40eb360

[FIX] Fix SEGFAULT that occured when using multiple instances of vpAR…

42fc48d

…Ogre

[TEST] Improved CI for Ogre

21643ab

[TEST] Improved CI for Ogre

55b5324

rolalaro force-pushed the ogre-1_12 branch from 21643ab to 55b5324 Compare January 10, 2025 07:05

LAGNEAU Romain added 4 commits January 10, 2025 08:06

Merge branch 'master' into ogre-1_12

fa83af1

[FIX] Fix resources loading when a resource does not exist

f832dbc

[FIX] Fixed HelloWorldOgre and HelloWorldOgreAdvanced

6059bcf

The window did not close when clicking on the [x] button of the window. Now it works

Merge branch 'ogre-1_12' into ogre-wip

b3d14d4

Clean vpAROgre examples

91cd1a6

- Introduce vpDisplayFactory - Remove useless try/catch and other code

LAGNEAU Romain added 3 commits January 14, 2025 08:38

[CORE] Improved resource loading

070fc49

[FIX] Fix segfault when using MBT with Ogre

e4bd734

The segfault came from the fact that the rendering window was added to the list of listening windows but not removed when destroyed

Merge branch 'ogre-1_12' of github.com:rolalaro/visp into ogre-1_12

4752089

LAGNEAU Romain and others added 8 commits January 14, 2025 11:20

[DOC] Added a tutorial in the documentation on how to use Ogre

5861d07

Update Ogre tutorial

3ddf8b2

Convert embedded image from png to jpg

73a3fc3

Update copyright date

5eac1c4

Update vp_parse_header() make macro doc

f9eecf1

Introduce OIS support.

7687472

I don't see since when OIS 3rdparty detection was removed!

Improve Ogre tutorial adding images

420c99b

Code cleaning

cae757c

This was referenced Jan 18, 2025

OIS 3rdparty not detected during CMake configuration #1546

Open

Dataset not detected when tests are disabled #1519

Open

Build issue with Ogre 1.12.0 or more recent versions #1547

Open

fspindle merged commit f6faf50 into lagadic:master Jan 18, 2025
104 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compatibility with more recent versions of Ogre #1538

Compatibility with more recent versions of Ogre #1538

rolalaro commented Jan 8, 2025

codecov bot commented Jan 10, 2025 •

edited

Loading

fspindle commented Jan 10, 2025

rolalaro commented Jan 14, 2025

fspindle commented Jan 18, 2025

Compatibility with more recent versions of Ogre #1538

Compatibility with more recent versions of Ogre #1538

Conversation

rolalaro commented Jan 8, 2025

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

fspindle commented Jan 10, 2025

rolalaro commented Jan 14, 2025

fspindle commented Jan 18, 2025

codecov bot commented Jan 10, 2025 •

edited

Loading