Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix 'errcheck' linter error #42

Merged
merged 2 commits into from
Oct 6, 2022
Merged

chore: Fix 'errcheck' linter error #42

merged 2 commits into from
Oct 6, 2022

Conversation

levaitamas
Copy link
Member

Detected in PR #41.

@coveralls
Copy link

coveralls commented Sep 29, 2022

Pull Request Test Coverage Report for Build 3153363694

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.691%

Totals Coverage Status
Change from base Build 3146676069: 0.0%
Covered Lines: 724
Relevant Lines: 1054

💛 - Coveralls

@levaitamas
Copy link
Member Author

On the second thought, we might not want to propagate the erros of the HTTP frontend. @rg0now wdyt?

@levaitamas levaitamas requested a review from rg0now September 29, 2022 17:41
@levaitamas levaitamas changed the title Fix the 'errcheck' linter error chore: Fix 'errcheck' linter error Oct 4, 2022
@levaitamas levaitamas merged commit 153e3b3 into main Oct 6, 2022
@levaitamas levaitamas deleted the fix-linter branch October 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants