M133 public #302
Open
M133 public #302
+80
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See python/cpython#128161 "Defining iterator in a separate class no longer works in 3.13" We have iterator for SkTextBlob defined by SkTextBlob::Iter(textblob), which is the c++/pybind11 equivalent of the same situation. Following the suggestion: python/cpython#128161 (comment) Also see actions/runner-images#11241 Fixes kyamagu#295
…88ac03 to canvaskit/0.38.2-6918-gc17fe9bc15)
….2-7362-gcddf7da9da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing interesting in this pull - just minimal routinely update to skia m133, and include #296 (breakage and compatibility with python 3.13.1).
@kyamagu : the mac ci has python 3.13.1 ; fedora also offers 3.13.1 from 3.13.0 about 3 weeks ago. There is probably a good reason to just push this out when people start to notice that pytthon 3.13.1 breaks. There are a number of good-to-go and work-in-progress pulls - I'd rather leave those until 134 (just to have a longer period between larger updates/additions).