Cast function should convert scientific notation to correct decimal value #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harveyyue
force-pushed
the
fix_scientific
branch
from
7e77a90 to
c8e147e
Compare
richox
reviewed
Feb 25, 2025
| } | ||
|
|
||
| fn scientific_to_string(s: &str) -> String { | ||
| match s.parse::<f64>() { |
There was a problem hiding this comment.
is there a precision loss when casting via floating point numbers?
There was a problem hiding this comment.
Yes, should use bigdecimal to handle it?
harveyyue
force-pushed
the
fix_scientific
branch
3 times, most recently
from
589eed7 to
fc324e4
Compare
harveyyue
force-pushed
the
fix_scientific
branch
from
54e92bd to
a846444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #843 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?