Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose kube-proxy metrics in old releases #11748

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Expose kube-proxy metrics in old releases #11748

merged 1 commit into from
Mar 13, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Mar 13, 2019

This PR is essentially reverting the #11313.
The underlying issue has been fixed in kubernetes/kubernetes#72682 and cherrypicked recently.

It should fix the kubernetes/kubernetes#75322

@mm4tt
Expose kube-proxy metrics in old releases
ad448f4 
This PR is essentially reverting
kubernetes#11313. The underlying
issue has been fixed in
kubernetes/kubernetes#72682 and cherrypicked
recently.

Ref. kubernetes/kubernetes#75322
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented Mar 13, 2019

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 13, 2019 07:50
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 62302b1c62eacd20fc872aa3cd5eb666a4b8d3ef

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3d10a41 into kubernetes:master Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

@mm4tt: Updated the job-config configmap in namespace default using the following files:

  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

This PR is essentially reverting the #11313.
The underlying issue has been fixed in kubernetes/kubernetes#72682 and cherrypicked recently.

It should fix the kubernetes/kubernetes#75322

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mm4tt mm4tt mentioned this pull request Mar 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm4tt @wojtek-t @k8s-ci-robot