Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade gomod to 1.22.1 #20270

Closed
wants to merge 1 commit into from
Closed

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jan 15, 2025

Go License doesnt like it

"make generate-licenses" needed for release

/home/jenkins/go/pkg/mod/github.com/klauspost/cpuid@v1.2.0/cpuid_amd64.s
E0115 22:04:16.908003   13843 library.go:117] Package expvar does not have module info. Non go modules projects are no longer supported. For feedback, refer to /~https://github.com/google/go-licenses/issues/128.
E0115 22:04:17.004589   13843 library.go:117] Package runtime/metrics does not have module info. Non go modules projects are no longer supported. For feedback, refer to /~https://github.com/google/go-licenses/issues/128.
E0115 22:04:17.293032   13843 library.go:117] Package database/sql does not have module info. Non go modules projects are no longer supported. For feedback, refer to /~https://github.com/google/go-licenses/issues/128.
W0115 22:04:18.735358   13843 library.go:101] "github.com/aregm/cpuid" contains non-Go code that can't be inspected for further dependencies:
/home/jenkins/go/pkg/mod/github.com/aregm/cpuid@v0.0.0-20181003105527-1a4a6f06a1c6/cpuidlow_amd64.s
F0115 22:04:18.833290   13843 main.go:77] some errors occurred when loading direct and transitive dependency packages
make: *** [Makefile:1272: generate-licenses] Error 1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

@medyagh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-build 825bda2 link true /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants