Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube addons list tests #12839

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

spowelljr
Copy link
Member

Follow up to #12837

Adding tests and fix JSON output.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 3, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12839) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.0s               |
| enable ingress | 31.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 48.1s 47.2s 47.3s 46.7s
Times for minikube (PR 12839) start: 47.5s 48.0s 45.9s 47.1s 46.8s

Times for minikube ingress: 32.8s 31.3s 32.4s 30.3s 31.8s
Times for minikube (PR 12839) ingress: 31.7s 31.3s 30.9s 31.3s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12839) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.2s               |
| enable ingress | 26.8s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 21.1s 21.0s 21.9s 21.9s
Times for minikube (PR 12839) start: 21.3s 21.7s 20.5s 20.2s 22.3s

Times for minikube ingress: 25.9s 26.5s 27.9s 27.4s 26.4s
Times for minikube (PR 12839) ingress: 34.9s 33.4s 28.4s 35.4s 27.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12839) |
+----------------+----------+---------------------+
| minikube start | 38.3s    | 41.7s               |
| enable ingress | 27.8s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 28.9s 45.8s 43.0s 30.2s 43.7s
Times for minikube (PR 12839) start: 43.1s 35.9s 43.8s 43.8s 41.8s

Times for minikube ingress: 29.4s 28.4s 32.9s 29.4s 19.0s
Times for minikube (PR 12839) ingress: 32.9s 26.4s 18.9s 32.5s 32.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 0.81 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 4.29 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 26.43 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 79.51 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/Stop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit 65ed4ad into kubernetes:master Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the addonListNotRunning branch November 17, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants