Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
  • Loading branch information
ArangoGutierrez and marquiz authored Jul 20, 2023
1 parent 406d7bc commit fbcaf7c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
- "-key-file=/etc/kubernetes/node-feature-discovery/certs/tls.key"
- "-cert-file=/etc/kubernetes/node-feature-discovery/certs/tls.crt"
{{- end }}
- "-metrics={{ .Values.worker.metricsPort | default "8081"}}"
- "-metrics={{ .Values.worker.metricsPort | default "8081"}}"
ports:
- name: metrics
containerPort: {{ .Values.worker.metricsPort | default "8081"}}
Expand Down
2 changes: 1 addition & 1 deletion deployment/helm/node-feature-discovery/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ worker:
# my.kernel.feature: {op: IsTrue}
# my.dummy.var: {op: Gt, value: ["0"]}
#
### <NFD-WORKER-CONF-END-DO-NOT-REMOVE>
### <NFD-WORKER-CONF-END-DO-NOT-REMOVE>

metricsPort: 8081
daemonsetAnnotations: {}
Expand Down
2 changes: 1 addition & 1 deletion docs/deployment/kustomize.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ kubectl apply -k /~https://github.com/kubernetes-sigs/node-feature-discovery/deplo

### Metrics

To allow [prometheus-operator][prometheus-operator]
To allow [prometheus operator][prometheus-operator]
to scrape metrics from node-feature-discovery,
run the following command:

Expand Down
2 changes: 1 addition & 1 deletion docs/deployment/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sort: 7

# Metrics

Metrics are configured to be exposed using [prometheus-operator](/~https://github.com/prometheus-operator/prometheus-operator)
Metrics are configured to be exposed using [prometheus operator](/~https://github.com/prometheus-operator/prometheus-operator)
API's by default. If you want to expose metrics using the prometheus operator
API's you need to install the prometheus operator in your cluster.
By default NFD Master and Worker expose metrics on port 8081.
Expand Down

0 comments on commit fbcaf7c

Please sign in to comment.