Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset scheduler configuration endpoint path #70

Closed
wants to merge 1 commit into from

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Dec 21, 2021

What type of PR is this?

/kind api-change

What this PR does / why we need it:

We cannot guess what PUT /api/v1/schedulerconfiguration will do.
(I should've pointed it when I reviewed #54 😓)

This PR change the endpoint to PUT /api/v1/schedulerconfiguration/reset

Which issue(s) this PR fixes:

Ref #26

Special notes for your reviewer:

This PR is not needed in case that we re-design #26 to create one API to reset all resources and scheduler config.
So, let me /hold this.

/cc @sivchari
/hold
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2021
@k8s-ci-robot
Copy link
Contributor

@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: sivchari.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind api-change

What this PR does / why we need it:

We cannot guess what PUT /api/v1/schedulerconfiguration will do.
(I should've pointed it when I reviewed #54 😓)

Which issue(s) this PR fixes:

Ref #26

Special notes for your reviewer:

This PR is not needed in case that we re-design #26 to create one API to reset all resources and scheduler config.
So, let me /hold this.

/cc @sivchari
/hold
/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2021
@sanposhiho
Copy link
Member Author

We re-designed #26. We will delete this API and create one API to reset all resources and scheduler config.
This PR is no longer needed.

/close

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: Closed this PR.

In response to this:

We re-designed #26. We will delete this API and create one API to reset all resources and scheduler config.
This PR is no longer needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants