change the Reset API to be called directly
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
sig/scheduling
k8s-ci-robot
added
lgtm
k8s-ci-robot
removed
the
lgtm
|
@sanposhiho Note: #163 was merged. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
sanposhiho
reviewed
May 16, 2022
Comment on lines
92
to
87
| const reset = async () => { | ||
| const Reset = async () => { |
There was a problem hiding this comment.
Rename it to resetFn (instead of Reset)
There was a problem hiding this comment.
@sanposhiho Thanks!
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 196Ikuchil, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle change the |
k8s-ci-robot
changed the title
Reset API directly on the Web UIReset API to be called directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
Resetfunction call doesn't store any data.So, I think that
ResetStoreis not needed.This PR removes these
storerelated files and fixes to call the API directly.Which issue(s) this PR fixes:
Fixes #152
Special notes for your reviewer:
This PR is including the contents of #163.
So, we should be merged after #163.
/label tide/merge-method-squash
/hold