-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browse-pvc manifest #3568
Add browse-pvc manifest #3568
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
Welcome @clbx! |
plugins/browse-pvc.yaml
Outdated
version: "v0.3.0" | ||
homepage: /~https://github.com/clbx/kubectl-browse-pvc | ||
shortDescription: "Browse PVCs from the command line" | ||
description: "Browse PVCs from the command line" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add a bit more detail here as to how the plugin does this task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
plugins/browse-pvc.yaml
Outdated
os: darwin | ||
uri: /~https://github.com/clbx/kubectl-browse-pvc/releases/download/v0.3/kubectl-browse-pvc-darwin.zip | ||
sha256: "0e0fc4e163e8434f9142edaa3b41fb1246e5c4dc652947284d6b8d49334601bd" | ||
files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit this field (as this value is the default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, clbx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello, I'd like to add my plugin browse-pvc to the krew repo. I constantly found myself spinning up dummy pods to exec into them so I could browse a PVC. I wrote this so I can easily, from the command line, easily get a shell with the PVC mounted.
I don't think there's something similar to this already in the repo. Please feel free to leave any feedback.