Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] 🐛 Restore v1alpha3/v1alpha4 conversion to fix SSA issue #2740

Merged
merged 3 commits into from
Feb 15, 2024
Merged

[release-1.9] 🐛 Restore v1alpha3/v1alpha4 conversion to fix SSA issue #2740

merged 3 commits into from
Feb 15, 2024

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
Manual cherry-pick of #2739

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2024
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-blocking-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-release-1-9
  • /test pull-cluster-api-provider-vsphere-verify-release-1-9

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-9

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-release-1-9
  • pull-cluster-api-provider-vsphere-e2e-blocking-release-1-9
  • pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • pull-cluster-api-provider-vsphere-test-release-1-9
  • pull-cluster-api-provider-vsphere-verify-release-1-9

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-release-1-9

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Comparison is base (1a425ce) 64.45% compared to head (3486fe4) 64.01%.
Report is 3 commits behind head on release-1.9.

Files Patch % Lines
apis/v1alpha3/cloudprovider_encoding.go 75.49% 33 Missing and 4 partials ⚠️
apis/v1alpha3/vsphereclusteridentity_conversion.go 0.00% 18 Missing ⚠️
apis/v1alpha3/vspherecluster_conversion.go 50.00% 12 Missing and 3 partials ⚠️
apis/v1alpha3/vspheremachine_conversion.go 55.88% 12 Missing and 3 partials ⚠️
apis/v1alpha3/vspheremachinetemplate_conversion.go 72.22% 12 Missing and 3 partials ⚠️
apis/v1alpha3/vspherevm_conversion.go 57.14% 12 Missing and 3 partials ⚠️
apis/v1alpha4/vspheremachine_conversion.go 57.14% 12 Missing and 3 partials ⚠️
apis/v1alpha4/vspheremachinetemplate_conversion.go 70.00% 12 Missing and 3 partials ⚠️
apis/v1alpha4/vspherevm_conversion.go 57.14% 12 Missing and 3 partials ⚠️
apis/v1alpha3/vspheredeploymentzone_conversion.go 0.00% 12 Missing ⚠️
... and 21 more
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.9    #2740      +/-   ##
===============================================
- Coverage        64.45%   64.01%   -0.45%     
===============================================
  Files              118      159      +41     
  Lines             8593     9291     +698     
===============================================
+ Hits              5539     5948     +409     
- Misses            2617     2884     +267     
- Partials           437      459      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member Author

sbueringer commented Feb 15, 2024 •
edited
Loading

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2740/pull-cluster-api-provider-vsphere-e2e-release-1-9/1757853890109247488/artifacts/clusters/clusterctl-upgrade-09dram/resources/capi-kubeadm-control-plane-system/Pod/capi-kubeadm-control-plane-controller-manager-786948c544-2p4nw.yaml

message: Back-off pulling image "registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.5.4"

Maybe we're hitting some quota / or some other registry issue

@sbueringer
Copy link
Member Author

/retest

chrischdi
chrischdi reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold to let you control

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df791fc8aa524ae2749af1d2e76d47c97b6a7ea6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-release-1-9

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-release-1-9

(just checking if I have to rebase after the Go bump)

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4ab4d31 into kubernetes-sigs:release-1.9 Feb 15, 2024
21 checks passed
@sbueringer sbueringer deleted the pr-1.9-fix-apiversion-issue branch February 15, 2024 12:06
@supershal supershal mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @chrischdi