Merge pull request #101 from PrasadG193/fix-timeout-calc

Fix timeout duration calculation
kubernetes-csi · Jan 8, 2025 · 0a22fca · 0a22fca
2 parents 925ae2b + 07228c0
commit 0a22fca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/sidecar/sidecar.go b/pkg/sidecar/sidecar.go
@@ -228,7 +228,7 @@ func (s *sidecarFlagSet) runtimeArgsToArgv(progName string, rta runtime.Args) []
 func (s *sidecarFlagSet) createServerConfig(rt *runtime.Runtime) grpc.ServerConfig {
 	return grpc.ServerConfig{
 		Runtime:      rt,
-		MaxStreamDur: time.Duration(*s.maxStreamingDurMin * 60),
+		MaxStreamDur: time.Duration(*s.maxStreamingDurMin) * time.Minute,
 	}
 }
 

diff --git a/pkg/sidecar/sidecar_test.go b/pkg/sidecar/sidecar_test.go
@@ -117,7 +117,7 @@ func TestSidecarFlagSet(t *testing.T) {
 		rt := &runtime.Runtime{}
 		config := sfs.createServerConfig(rt)
 		assert.Equal(t, rt, config.Runtime)
-		assert.Equal(t, time.Duration(defaultMaxStreamingDurationMin*60), config.MaxStreamDur)
+		assert.Equal(t, time.Duration(defaultMaxStreamingDurationMin)*time.Minute, config.MaxStreamDur)
 	})
 }