Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Istio version references to v1.16 #2332

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Update Istio version references to v1.16 #2332

merged 3 commits into from
Nov 25, 2022

Conversation

apo-ger
Copy link
Contributor

@apo-ger apo-ger commented Nov 24, 2022 •
edited
Loading

Follow-up PR from: #2327

  • Update Istio version reference in main README file
  • Replace all references of istio-1-14 with istio-1-16
    • installation instructions in README
    • helper scripts
  • Minor fixes for GH Action workflows

Refs: #2325

cc. @kimwnasptd
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com

@apo-ger
Update Istio version in README file
c13e691 
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
@apo-ger
Fix GH action workflows
568b105 
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Nov 24, 2022
farshadghodsian
farshadghodsian suggested changes Nov 24, 2022
View reviewed changes
Copy link

@farshadghodsian farshadghodsian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main Readme file install instructions need to be changed to reference the new directory for istio-1-16 (Lines139-141)
kustomize build common/istio-1-16/istio-crds/base | kubectl apply -f -
kustomize build common/istio-1-16/istio-namespace/base | kubectl apply -f -
kustomize build common/istio-1-16/istio-install/base | kubectl apply -f -

@paulbehrisch
Copy link

In fact just do a find istio-1-14 and replace it with istio-1-16

@paulbehrisch
Copy link

paulbehrisch commented Nov 24, 2022 •
edited
Loading

I did a quick ack and found more references to istio-1-14, which can't work as the istio-1-14 folder under common is removed.

tests/gh-actions/install_knative.sh
9:kustomize build common/istio-1-14/kubeflow-istio-resources/base | kubectl apply -f -

hack/setup-kubeflow-light.sh
33:kustomize build common/istio-1-14/istio-crds/base | kubectl apply -f -
34:kustomize build common/istio-1-14/istio-namespace/base | kubectl apply -f -
35:kustomize build common/istio-1-14/istio-install/base | kubectl apply -f -
53:kustomize build common/istio-1-14/cluster-local-gateway/base | kubectl apply -f -

README.md
64:| Istio | common/istio-1-14 | [1.14.1](/~https://github.com/istio/istio/releases/tag/1.14.1) |
139:kustomize build common/istio-1-14/istio-crds/base | kubectl apply -f -
140:kustomize build common/istio-1-14/istio-namespace/base | kubectl apply -f -
141:kustomize build common/istio-1-14/istio-install/base | kubectl apply -f -
170:kustomize build common/istio-1-14/cluster-local-gateway/base | kubectl apply -f -
212:kustomize build common/istio-1-14/kubeflow-istio-resources/base | kubectl apply -f -```

@apo-ger
Update README install instructions for Istio-1-16
2c2f005 
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
@apo-ger apo-ger force-pushed the update-istio-version-in-readme branch from 23a7752 to 2c2f005 Compare November 24, 2022 15:34
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Nov 24, 2022
farshadghodsian
farshadghodsian approved these changes Nov 24, 2022
View reviewed changes
Copy link

@farshadghodsian farshadghodsian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you for making the update! 👍

@apo-ger apo-ger changed the title Update Istio version in README file Update Istio version references to v1.16 Nov 24, 2022
@kimwnasptd
Copy link
Member

kimwnasptd commented Nov 25, 2022 •
edited
Loading

At this point I think that following the istio-<version> convention introduces some toil that we could avoid by sticking to just an common/istio folder.

I see that we have a common/istio folder, with deprecated code that was used to support the use-case of "single user" installation. I'll open an issue to track the deprecation of that folder

@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 25, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apo-ger, kimwnasptd, learning-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f24b944 into kubeflow:master Nov 25, 2022
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
@apo-ger @kevin85421
Update Istio version references to v1.16 (kubeflow#2332)
4406a38 
* Update Istio version in README file

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Fix GH action workflows

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update README install instructions for Istio-1-16

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farshadghodsian farshadghodsian farshadghodsian approved these changes

@elikatsis elikatsis Awaiting requested review from elikatsis

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@kimwnasptd kimwnasptd

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apo-ger @paulbehrisch @kimwnasptd @farshadghodsian