Fix deadlock in token reloading #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
nightkr
approved these changes
Feb 16, 2022
|
@clux Or we could create a separate 0.69 branch that we cherry-pick this merge into. |
|
yeah, that would be even better actually. |
|
Ok, got a repro running, and this seems to fix it. |
nightkr
added a commit
to nightkr/kube-rs
that referenced
this pull request
Feb 16, 2022
Fix deadlock in token reloading
nightkr
added a commit
to nightkr/kube-rs
that referenced
this pull request
Feb 16, 2022
Fix deadlock in token reloading Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
kazk
reviewed
Feb 16, 2022
| bearer_header(token) | ||
| } else { | ||
| bearer_header(token_file.write().await.token()) | ||
| bearer_header(locked.token()) | ||
| } |
There was a problem hiding this comment.
So, this can lead to the deadlock explained in the docs?
Note that under the priority policy of
RwLock, read locks are not granted until prior write locks, to prevent starvation. Therefore deadlock may occur if a read lock is held by the current task, a write lock attempt is made, and then a subsequent read lock attempt is made by the current task.Returns an RAII guard which will drop this read access of the
RwLockwhen dropped.
I thought the RwLockReadGuard from .read().await is dropped before the else block :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lock at one point before entering the branch to prevent two locks being attempted