Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] skip window creation on auth exec #1095

Merged
merged 5 commits into from
Dec 6, 2022
Merged

[windows] skip window creation on auth exec #1095

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53cb6ce
don't create a window for auth exec
goenning Dec 2, 2022
44b2d55
rust fmt
goenning Dec 2, 2022
b9368a6
move it close to other imports
goenning Dec 2, 2022
21eeb25
Update kube-client/src/client/auth/mod.rs
goenning Dec 3, 2022
a773201
Merge branch 'main' into go/create-no-window
clux Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions kube-client/src/client/auth/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use std::{
sync::Arc,
};


use chrono::{DateTime, Duration, Utc};
use futures::future::BoxFuture;
use http::{
Expand All @@ -21,6 +22,7 @@ use crate::config::{AuthInfo, AuthProviderConfig, ExecConfig};

#[cfg(feature = "oauth")] mod oauth;
#[cfg(feature = "oauth")] pub use oauth::Error as OAuthError;
#[cfg(target_os = "windows")] use std::os::windows::process::CommandExt;

#[derive(Error, Debug)]
/// Client auth errors
Expand Down Expand Up @@ -497,6 +499,12 @@ fn auth_exec(auth: &ExecConfig) -> Result<ExecCredential, Error> {
}
}

#[cfg(target_os = "windows")]
{
static CREATE_NO_WINDOW: u32 = 0x08000000;
cmd.creation_flags(CREATE_NO_WINDOW);
}

let out = cmd.output().map_err(Error::AuthExecStart)?;
if !out.status.success() {
return Err(Error::AuthExecRun {
Expand Down