can avoid making name public since we have a getter

Signed-off-by: clux <sszynrae@gmail.com>
kube-rs · May 23, 2022 · 2888608 · 2888608
1 parent bcaf4f0
commit 2888608
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/kube-client/src/discovery/apigroup.rs b/kube-client/src/discovery/apigroup.rs
@@ -64,7 +64,7 @@ use std::cmp::Reverse;
 /// [`ApiGroup::recommended_kind`]: crate::discovery::ApiGroup::recommended_kind
 pub struct ApiGroup {
     /// Name of the group e.g. apiregistration.k8s.io
-    pub name: String,
+    name: String,
     /// List of resource information, capabilities at particular versions
     data: Vec<GroupVersionData>,
     /// Preferred version if exported by the `APIGroup`

diff --git a/kube-client/src/discovery/mod.rs b/kube-client/src/discovery/mod.rs
@@ -143,7 +143,7 @@ impl Discovery {
     pub fn groups_alphabetical(&self) -> Vec<&ApiGroup> {
         let mut values: Vec<_> = self.groups().collect();
         // collect to maintain kubectl order of groups
-        values.sort_by_key(|g| &g.name);
+        values.sort_by_key(|g| g.name());
         values
     }