adds option to force disable multi-view #436
clippy
118 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 118 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a62 2024-11-26)
Annotations
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:394:17
|
394 | / tokio::select! {
395 | | _ = connection::connection_lifecycle_loop() => (),
396 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
397 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:394:17
|
394 | / tokio::select! {
395 | | _ = connection::connection_lifecycle_loop() => (),
396 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
397 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:241:13
|
241 | / tokio::select! {
242 | | _ = web_server => (),
243 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
244 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:241:13
|
241 | / tokio::select! {
242 | | _ = web_server => (),
243 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
244 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 54 in alvr\server\src\lib.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\server\src\lib.rs:54:30
|
54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:1107:9
|
1107 | / tokio::join!(
1108 | | async {
1109 | | alvr_common::show_err(connection_pipeline().await);
... |
1114 | | time::sleep(RETRY_CONNECT_MIN_INTERVAL),
1115 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:1071:5
|
1071 | / tokio::select! {
1072 | | // Spawn new tasks and let the runtime manage threading
1073 | | res = spawn_cancelable(receive_loop) => {
1074 | | alvr_session::log_event(ServerEvent::ClientDisconnected);
... |
1101 | | }
1102 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:1071:5
|
1071 | / tokio::select! {
1072 | | // Spawn new tasks and let the runtime manage threading
1073 | | res = spawn_cancelable(receive_loop) => {
1074 | | alvr_session::log_event(ServerEvent::ClientDisconnected);
... |
1101 | | }
1102 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1019 in alvr\server\src\connection.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> alvr\server\src\connection.rs:1019:59
|
1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.indices.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
Check warning on line 1019 in alvr\server\src\connection.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> alvr\server\src\connection.rs:1019:28
|
1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.vertices.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:594:25
|
594 | let stream_socket = tokio::select! {
| _________________________^
595 | | res = StreamSocketBuilder::connect_to_client(
596 | | client_ip,
597 | | settings.connection.stream_port,
... |
605 | | }
606 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:594:25
|
594 | let stream_socket = tokio::select! {
| _________________________^
595 | | res = StreamSocketBuilder::connect_to_client(
596 | | client_ip,
597 | | settings.connection.stream_port,
... |
605 | | }
606 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:542:9
|
542 | / tokio::select! {
543 | | res = try_connection_future => {
544 | | match res {
545 | | Either::Left(Ok(client_ip)) => {
... |
562 | | _ = CLIENTS_UPDATED_NOTIFIER.notified() => return Ok(()),
563 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:542:9
|
542 | / tokio::select! {
543 | | res = try_connection_future => {
544 | | match res {
545 | | Either::Left(Ok(client_ip)) => {
... |
562 | | _ = CLIENTS_UPDATED_NOTIFIER.notified() => return Ok(()),
563 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `#[warn(clippy::incompatible_msrv)]` on by default
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 88 in alvr\server\src\connection.rs
github-actions / clippy
field `version` is never read
warning: field `version` is never read
--> alvr\server\src\connection.rs:88:5
|
86 | struct ConnectionInfo {
| -------------- field in this struct
87 | client_ip: IpAddr,
88 | version: Option<Version>,
| ^^^^^^^
Check warning on line 53 in alvr\server\src\connection.rs
github-actions / clippy
field `hostname` is never read
warning: field `hostname` is never read
--> alvr\server\src\connection.rs:53:5
|
52 | struct ClientId {
| -------- field in this struct
53 | hostname: String,
| ^^^^^^^^
|
= note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 19 in alvr\server\src\lib.rs
github-actions / clippy
unused import: `prelude::*`
warning: unused import: `prelude::*`
--> alvr\server\src\lib.rs:19:37
|
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
| ^^^^^^^^^^
Check warning on line 8 in alvr\server\src\connection.rs
github-actions / clippy
unused imports: `Mat4` and `log`
warning: unused imports: `Mat4` and `log`
--> alvr\server\src\connection.rs:8:12
|
8 | glam::{Mat4, Quat, Vec2, Vec3},
| ^^^^
9 | log,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 638 in alvr\audio\src\lib.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> alvr\audio\src\lib.rs:638:17
|
638 | &mut *self.sample_buffer.lock(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut self.sample_buffer.lock()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\sockets\src\lib.rs:74:17
|
74 | / tokio::select! {
75 | | res = future => res,
76 | | _ = cancel_receiver => Ok(()),
77 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\sockets\src\lib.rs:74:17
|
74 | / tokio::select! {
75 | | res = future => res,
76 | | _ = cancel_receiver => Ok(()),
77 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `#[warn(clippy::incompatible_msrv)]` on by default
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 220 in alvr\sockets\src\stream_socket\mod.rs
github-actions / clippy
field `stream_id` is never read
warning: field `stream_id` is never read
--> alvr\sockets\src\stream_socket\mod.rs:220:5
|
219 | pub struct StreamReceiver<T> {
| -------------- field in this struct
220 | stream_id: StreamId,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 1 in alvr\sockets\src\packets.rs
github-actions / clippy
unused import: `collections::HashMap`
warning: unused import: `collections::HashMap`
--> alvr\sockets\src\packets.rs:1:11
|
1 | use std::{collections::HashMap, time::Duration};
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 617 in alvr\session\src\lib.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\session\src\lib.rs:617:53
|
617 | let session_desc = match fs::read_to_string(&session_path) {
| ^^^^^^^^^^^^^ help: change this to: `session_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 4 in alvr\session\src\settings.rs
github-actions / clippy
unused import: `DictionaryDefault`
warning: unused import: `DictionaryDefault`
--> alvr\session\src\settings.rs:4:23
|
4 | use settings_schema::{DictionaryDefault, EntryData, SettingsSchema, Switch, SwitchDefault};
| ^^^^^^^^^^^^^^^^^